cool#9992 doc sign: fix handling of saveas options containing spaces #10409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
But passes for me, retry. |
|
Ah and this is about saveas, not load, let me fix the commit message. |
Trying to create signed PDFs during ODT->PDF conversion, a signature is
created, but it's not valid. The first trouble noticed while
investigating is that the saveas option we get is like this:
debug:666:660: doc_saveAs: pFilterOptions is '{"SignPDF":{"type":"boolean","value":"true"},"SignCertificateCaPem":{"type":"string","value":"-----BEGINCERTIFICATE-----
While this should be '-----BEGIN CERTIFICATE-----', since the syntax is
"saveas ... [options=<options>]".
Fix the problem in ChildSession::saveAs(), where a space was lost while
"saveas ... options=foo bar" was tokenized as "saveas", "...", "options=foo"
and "bar", and later we constructed <options> as "foobar", not "foo
bar".
Signed-off-by: Miklos Vajna <vmiklos@collabora.com>
Change-Id: Ibadcb3218d8776191193ca13788cfca4a8d1e11d
vmiklos
force-pushed
the
private/vmiklos/master
branch
from
0e29f0b to
9a29f0c
Compare
vmiklos
changed the title
|
@caolanm could you please review this? Thanks. At least now the input for the PDF signature looks good. The binary signature still has some bug that I need to debug, but this is a precondition, otherwise the CA chain will have missing items. |
caolanm
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to create signed PDFs during ODT->PDF conversion, a signature is
created, but it's not valid. The first trouble noticed while
investigating is that the load option we get is like this:
debug:666:660: doc_saveAs: pFilterOptions is '{"SignPDF":{"type":"boolean","value":"true"},"SignCertificateCaPem":{"type":"string","value":"-----BEGINCERTIFICATE-----
While this should be '-----BEGIN CERTIFICATE-----', since the syntax is
"load ... [options=]".
Fix the problem in ChildSession::saveAs(), where a space was lost while
"load ... options=foo bar" was tokenized as "load", "...", "options=foo"
and "bar", and later we constructed as "foobar", not "foo
bar".
Signed-off-by: Miklos Vajna vmiklos@collabora.com
Change-Id: Ibadcb3218d8776191193ca13788cfca4a8d1e11d